Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fixes deprecated calls to jQuery trim. Fixes #2327 #2328

Merged
merged 3 commits into from May 13, 2020
+9 −2
Merged

Core: Fixes deprecated calls to jQuery trim. Fixes #2327 #2328

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb6c991
Core: Fixes deprecated calls to jQuery trim. Fixes #2327
May 7, 2020
540bcae
Core: Adds on trim method w/o overwriting native trim. Fixes #2327
May 7, 2020
f1e2d6f
Core: Trim method added and moved down to where needed. Fixes #2327
May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/core.js
View file
Open in desktop
@@ -1,3 +1,12 @@
// JQuery trim is deprecated, polyfill native js method if not defined
if ( !String.prototype.trim ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not pollute the prototype of builtin objects. Please instead create a local trim-function instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trim#Polyfill
String.prototype.trim = function() {
return this.replace( /^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g, "" );
};
}

$.extend( $.fn, {

// https://jqueryvalidation.org/validate/
Expand Down Expand Up @@ -203,13 +212,13 @@ $.extend( $.expr.pseudos || $.expr[ ":" ], { // '|| $.expr[ ":" ]' here enables

// https://jqueryvalidation.org/blank-selector/
blank: function( a ) {
return !$.trim( "" + $( a ).val() );
return !( "" + $( a ).val() ).trim();
},

// https://jqueryvalidation.org/filled-selector/
filled: function( a ) {
var val = $( a ).val();
return val !== null && !!$.trim( "" + val );
return val !== null && !!( "" + val ).trim();
},

// https://jqueryvalidation.org/unchecked-selector/
Expand Down