Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fixes deprecated calls to jQuery trim. Fixes #2327 #2328

Merged
merged 3 commits into from May 13, 2020
Merged

Core: Fixes deprecated calls to jQuery trim. Fixes #2327 #2328

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb6c991
Core: Fixes deprecated calls to jQuery trim. Fixes #2327
May 7, 2020
540bcae
Core: Adds on trim method w/o overwriting native trim. Fixes #2327
May 7, 2020
f1e2d6f
Core: Trim method added and moved down to where needed. Fixes #2327
May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/core.js
View file
Open in desktop
@@ -1,3 +1,10 @@
// JQuery trim is deprecated, provide a trim method based on String.prototype.trim
function trim( str ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the function into a local variable and move it down to the functions where it is used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trim#Polyfill
return str.replace( /^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g, "" );
}

$.extend( $.fn, {

// https://jqueryvalidation.org/validate/
Expand Down Expand Up @@ -203,13 +210,13 @@ $.extend( $.expr.pseudos || $.expr[ ":" ], { // '|| $.expr[ ":" ]' here enables

// https://jqueryvalidation.org/blank-selector/
blank: function( a ) {
return !$.trim( "" + $( a ).val() );
return !trim( "" + $( a ).val() );
},

// https://jqueryvalidation.org/filled-selector/
filled: function( a ) {
var val = $( a ).val();
return val !== null && !!$.trim( "" + val );
return val !== null && !!trim( "" + val );
},

// https://jqueryvalidation.org/unchecked-selector/
Expand Down