component: Chrome autofill bugfix #2230
Conversation
|
Could you elaborate a bit why this change fixes your problem? The newly added config key is rather cryptic named, I dont know what it does...? Why do we need this new config flag after alll? |
|
Any form element (button, input etc.) inserted by javascript trigger chrome autofill. |
Rename option key
| @@ -58,7 +58,7 @@ $.extend( $.fn, { | |||
| // - A user defined a `submitHandler` | |||
| // - There was a pending request due to `remote` method and `stopRequest()` | |||
| // was called to submit the form in case it's valid | |||
| if ( validator.submitButton && ( validator.settings.submitHandler || validator.formSubmitted ) && !validator.settings.disableSubmitSec ) { | |||
| if ( validator.submitButton && ( validator.settings.submitHandler || validator.formSubmitted ) && !validator.settings.disableHiddenInput ) { | |||
|
as I read the comment in the source, I am wondering, why you use a form without a explicit submit button? |
|
Any variation of form doesn't work (even from example files). If i doesn't disable this option by |
|
hmm not sure this solution is a good fit. @Arkni any opinions/ideas on this? |
|
I'm also not sure about this solution. When someone change password and doesn't confirm this to chrome when he try to login injecting any button, input etc. restore form fields. I need find way to fix this, not skip. Why incjecting input is required when user define
This can't be replaced by attribute or store in variable? |
|
Hi @szmagli, I can't test it right now, but could setting |
|
@Arkni i tried but onload aoutocomplete should be on, before i call validation i try to change to off, password field to autocolplete="new-password" but chrome ignore that. |
| // - A user defined a `submitHandler` | ||
| // - There was a pending request due to `remote` method and `stopRequest()` | ||
| // was called to submit the form in case it's valid | ||
| if ( validator.submitButton && ( validator.settings.submitHandler || validator.formSubmitted ) ) { | ||
| if ( validator.submitButton && ( validator.settings.submitHandler || validator.formSubmitted ) && !validator.settings.disableHiddenInput ) { | ||
| hidden = $( "<input type='hidden'/>" ) |
There was a problem hiding this comment.
Arknis idea was to add autocomplete off to this input which is beeing injected
resolve #2228
Description
Thank you!