Core: simplify destroy method #2183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure we can do this change, as people might rely on this classnames for css and/or js. A github code search could give an answer to this question... |
|
I did a search and all I can find is our own source code. I even check the source code of But I guess, it would be best suitable for v2. /cc @RobJohnston: wdyt about this? |
|
I don't have any great insight, as JavaScript isn't my bailiwick. When I wrote those methods, I was following the pattern. |
staabm
approved these changes
Jun 20, 2018
|
Thanks for the input @RobJohnston |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.