Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Stale bot #2176

Merged
merged 1 commit into from Jun 5, 2018
Merged

Add support for Stale bot #2176

merged 1 commit into from Jun 5, 2018

Conversation

Arkni
Copy link
Member

@Arkni Arkni commented Jun 4, 2018

I will install the bots on this repo after we agree on the message of the comments.

Ref #2127

/cc @staabm

@Arkni Arkni changed the title Stale no response bots Add support for Stale and No-response bots Jun 4, 2018
staabm
staabm reviewed Jun 4, 2018
View reviewed changes
.github/stale.yml Outdated
This issue has been automatically marked as idle and stale because it hasn't
had any recent activity. It will be automtically closed if no further activity
occurs. If you think this is wrong, or the problem still persists, just pop
a reply in the comments and @staabm or @Arkni will (try!) to follow up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please dont mention us... the bot will spam us with notifications ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I forgot why I put them in there.

I will replace them with one of the maintainers

staabm
staabm reviewed Jun 4, 2018
View reviewed changes
.github/stale.yml Outdated
# Issues with these labels will never be considered stale
exemptLabels:
- bug
- "MERGE ME"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add "help wanted" here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also "NEEDS REVIEW"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I should add those too.

@Arkni Arkni force-pushed the stale-no-response-bots branch 3 times, most recently from a55ea53 to 7050cf6 Compare June 4, 2018 10:17
@Arkni
Copy link
Member Author

Arkni commented Jun 4, 2018

@staabm Updated per above suggestions

@staabm
Copy link
Member

staabm commented Jun 4, 2018

in case we miss something in the config, does the bot support some kind of rollback, so we dont need to batch-update all issues in case of a mistake?

@Arkni
Copy link
Member Author

Arkni commented Jun 4, 2018 •
edited

As far as I know, none of the two bots support a rollback action.

The no-response bot only support 3 options, which we already use. As for the Stale bot, there are still some usefull options to use. For example, exemptMilestones that can be used to ignore issues or pull requests that are part of a milestone. We can also use only option to limit the bot to issues only or pull requests (by default, it manage the two).

For more options, see https://github.com/probot/stale#usage

@Arkni
Copy link
Member Author

Arkni commented Jun 4, 2018

Also, forgot to mention that the no-response bot has a annoying issue when the original poster closed the issue, see probot/no-response#16

@staabm
Copy link
Member

staabm commented Jun 4, 2018 •
edited

maybe we should start with the "stale" bot only and see how things go.

the other bot config file could be stored in a separate PR for later merge.

@Arkni
Copy link
Member Author

Arkni commented Jun 4, 2018

Sounds good to me. I will update the PR later today.

@Arkni Arkni changed the title Add support for Stale and No-response bots Add support for Stale bot Jun 5, 2018
@Arkni
Copy link
Member Author

Arkni commented Jun 5, 2018

Update per above suggestion. I think we are good to go.

@Arkni
Copy link
Member Author

Arkni commented Jun 5, 2018

I broke the PR into two:

@staabm
Copy link
Member

staabm commented Jun 5, 2018

ok cool, thank you.

@staabm staabm merged commit 934822b into jquery-validation:master Jun 5, 2018
@Arkni Arkni deleted the stale-no-response-bots branch June 5, 2018 12:33
@Arkni
Copy link
Member Author

Arkni commented Jun 5, 2018

I have sent an installation request to jquery-validation. As you're the one who created this org, only you have the right to accept the request.

@staabm staabm mentioned this pull request Jun 5, 2018
Closed
@jzaefferer
Copy link
Collaborator

Should the bot apply to all repos, or only this one?

@staabm
Copy link
Member

staabm commented Jun 5, 2018

we don't have "Issues"-tab activated in the other reposes

@jzaefferer
Copy link
Collaborator

I guess you already approved it? I'm not sure based on the email notification and Apps UI...

@staabm
Copy link
Member

staabm commented Jun 5, 2018

yep, I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Arkni @staabm @jzaefferer