Fix 'step', 'min' & 'max' controls on date/time inputs

[ElGigi]

Checklist for this pull request

Before submitting a pull request, please make sure to follow these rules:

• Your code should contain tests relevant for the problem you are solving.
• Your commits messages format should follow the jQuery git commit message format (http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines).
• The pull request should reference existing issues or link to a reproducible demo.
• Please review the guidelines for contributing (CONTRIBUTING.md) to this repository for more information.

Description

In reference to issue: #2023

It's a solution for jquery-validation to support attributes: 'step', 'min' and 'max' on inputs of type : 'time', 'date', 'datetime', 'datetime-local', 'month' and 'week'.

It respond to:

jquery-validation/src/core.js

Line 1463 in 6ff4a02

// TODO find a way to support input types date, datetime, datetime-local, month, time and week

Specifications: https://html.spec.whatwg.org/multipage/input.html#local-date-and-time-state-(type%3Ddatetime-local)

[staabm]

A good first step would be to answer all the questions inside the PR description.

Atm this code changes are useless.

[ElGigi]

Done, i hope that is ok for you ;).

[stale]

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up.
Thank you for contributing :)

[derkaiserreich]

Could this be reopened again as it is basically solved?

[Arkni]

Sorry for this. I'll reopen it and will try to review it when I got some free time.

[khansamad47]

Can this please be fixed

[staabm]

@khansamad47 what exact problem do you see and does this fix provided here solve it?

[Tomanlu]

In what state is this issue? Can it be fixed?

[jameswilson]

I'm seeing that this desperately needs tests to move forward. Sadly, tests were never added to this PR, per requested checklist in PR summary:

Your code should contain tests relevant for the problem you are solving.

When I went to test this using Drupal's Clientside Validation module via patch adapted from the code in this pr, I immediately hit an issue where a date field should clearly pass, but fails.

Relevant HTML snippet from Drupal, that could be adapted/simplified into a test case:

Min/Max is not calculated correctly:
<input
  type="date"
  placeholder="YYYY-MM-DD"
  min="1902-01-01"
  max="2037-12-31"
  name="date"
  value="2022-02-22"
  size="12"
/>
<input
  type="time"
  step="1"
  placeholder="hh:mm:ss"
  name="time"
  value="09:14:19"
  size="12"
/>

I've setup a very complete jsbin to compare native html5 validation with each date type that demonstrates several issues related to min/max calculations and breakage due to the "step" attribute.

https://jsfiddle.net/w8jpygr2/

[omahane]

It's been a couple years, @ElGigi . Have you had a chance to revisit this?

[ElGigi]

It's been a couple years, @ElGigi . Have you had a chance to revisit this?

I tried to fix it, but unfortunately I no longer use the library since I no longer use jQuery.