New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed validation for named array within form validation (works for name="xyz" and name="xyz[]") both #2000
base: master
Are you sure you want to change the base?
Conversation
Build is failing because of missing spaces after ( ) and a new line before comment. rest is fine |
@Saurabh-Sharma i run into the same issue. Your patch works for me. why did you close this PR? |
If a form input has a name="xyz[]" then only first element with name="xyz[]" is validated and rest are ignored.
@gimler Reopened, need to update test cases |
This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. |
still an issue the fix works |
Checks are failing due to test cases, which are expecting validation on single field. which is exactly not the case here.
|
@Saurabh-Sharma Hi, |
1.18.0 still in issue. The PR works fine for me. |
Description
If a form input has a name="xyz[]" then only first element with name="xyz[]" is validated and rest are ignored.
This fix adds the flexibility for validating the named array (name="xyz[]") or a single name attribute (name="xyz") with no extra effort
Thank you!