Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isHexColor.js #1973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

isHexColor.js #1973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/additional/ishexcolor.js
View file
Open in desktop
@@ -0,0 +1,3 @@
$.validator.addMethod( "ishexcolor", function( value, element ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the name to hexcolor in order to be consistent with other additional methods?
Also, I would like the file to be renamed to hexcolor as well.

return this.optional( element ) || /^#(?:[0-9a-f]{6}|[0-9a-f]{3})$/i.test( value );
}, "This is not hex format color" );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this message to something like: Please specify a valid hex color value