additional date german

[ltdeta]

adopted from additional dateITA

[staabm]

please remove the else block. the var is already initialised with this value.

[staabm]

Thx for the PR. Please add tests

[ltdeta]

Thx for the PR. Please add tests

What does it actually mean ?

[Arkni]

Hi @ltdeta,

It means you need to add some test for the new method, like it's done with dateITA in

jquery-validation/test/methods.js

Lines 877 to 884 in 934822b

	QUnit.test( "dateITA", function( assert ) {
	var method = methodTest( "dateITA" );
	assert.ok( method( "01/01/1900" ), "Valid date ITA" );
	assert.ok( method( "17/10/2010" ), "Valid date ITA" );
	assert.ok( !method( "01/13/1990" ), "Invalid date ITA" );
	assert.ok( !method( "01.01.1900" ), "Invalid date ITA" );
	assert.ok( !method( "01/01/199" ), "Invalid date ITA" );
	} );

[ltdeta]

Here are some tests for the new method

QUnit.test( "dateGER", function( assert ) {
	var method = methodTest( "dateGER" );
	assert.ok( method( "01.01.1900" ), "Valid date GER" );
	assert.ok( method( "17.10.2010" ), "Valid date GER" );
	assert.ok( method( "17.6.1878" ), "Valid date GER" );
	assert.ok( method( "2.6.1870" ), "Valid date GER" );
		
	assert.ok( !method( "01.13.1990" ), "Invalid date GER" );
	assert.ok( !method( "32.05.1990" ), "Invalid date GER" );	
	assert.ok( !method( "00.01.1900" ), "Invalid date GER" );
	assert.ok( !method( "01.02.199" ), "Invalid date GER" );
        assert.ok( !method( "01.02.99" ), "Invalid date GER" );	
	assert.ok( !method( "00.00.1900" ), "Invalid date GER" );
	assert.ok( !method( "0.00.1900" ), "Invalid date GER" );
	assert.ok( !method( "0.0.1900" ), "Invalid date GER" );
} );

[Arkni]

HI @ltdeta,

Sorry for taking so long to respond to you comment. Can you please add those tests after

jquery-validation/test/methods.js

Lines 877 to 884 in 934822b

	QUnit.test( "dateITA", function( assert ) {
	var method = methodTest( "dateITA" );
	assert.ok( method( "01/01/1900" ), "Valid date ITA" );
	assert.ok( method( "17/10/2010" ), "Valid date ITA" );
	assert.ok( !method( "01/13/1990" ), "Invalid date ITA" );
	assert.ok( !method( "01.01.1900" ), "Invalid date ITA" );
	assert.ok( !method( "01/01/199" ), "Invalid date ITA" );
	} );

and push the changes.

After that I will merge the PR.

Thanks!