Core: fix remote validation when input is the same as in aborted requ…

…est (#2481)

Fixes #2479

src/core.js

@@ -1594,11 +1594,12 @@ $.extend( $.validator, {
 
 			param = typeof param === "string" && { url: param } || param;
 			optionDataString = $.param( $.extend( { data: value }, param.data ) );
-			if ( previous.old === optionDataString ) {
+			if ( previous.valid !== null && previous.old === optionDataString ) {
 				return previous.valid;
 			}
 
 			previous.old = optionDataString;
+			previous.valid = null;
 			validator = this;
 			this.startRequest( element );
 			data = {};

test/methods.js

@@ -623,7 +623,7 @@ QUnit.test( "remote, data previous querystring", function( assert ) {
 			rules: {
 				lastname: {
 					remote: {
-						url: "users.php",
+						url: "users3.php",
 						type: "POST",
 						data: {
 							firstname: function() {
@@ -839,6 +839,42 @@ QUnit.test( "Fix #2434: race condition in remote validation rules", function( as
 	} );
 } );
 
+QUnit.test( "Fix #2479: Remote validation fails when input is the same as in aborted request", function( assert ) {
+	var e = $( "#username" ),
+		done1 = assert.async(),
+		v = $( "#userForm" ).validate( {
+			rules: {
+				username: {
+					remote: {
+						url: "users.php"
+					}
+				}
+			},
+			messages: {
+				username: {
+					remote: $.validator.format( "{0} in use" )
+				}
+			}
+		} );
+
+	e.val( "Peter" );
+	v.element( e );
+	assert.equal( e.hasClass( "error" ), false, "Field 'username' should not have the error class" );
+	assert.equal( e.hasClass( "pending" ), true, "field 'username' should have the pending class" );
+
+	e.val( "Peter" );
+	v.element( e );
+	assert.equal( e.hasClass( "error" ), false, "Field 'username' should not have the error class" );
+	assert.equal( e.hasClass( "pending" ), true, "field 'username' should have the pending class" );
+
+	setTimeout( function() {
+		assert.equal( v.errorList[ 0 ].message, "Peter in use" );
+		assert.equal( e.hasClass( "error" ), true, "Field 'username' should have the error class" );
+		assert.equal( e.hasClass( "pending" ), false, "field 'username' should not have the pending class" );
+		done1();
+	} );
+} );
+
 QUnit.module( "additional methods" );
 
 QUnit.test( "phone (us)", function( assert ) {

test/test.js

@@ -31,6 +31,16 @@ $.mockjax( {
 	responseTime: 1
 } );
 
+$.mockjax( {
+	url: "users3.php",
+	data: {
+		lastname: "last-name"
+	},
+	responseText: "false",
+	responseStatus: 200,
+	responseTime: 1
+} );
+
 $.mockjax( {
 	url: "echo.php",
 	response: function( data ) {