Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing undefined options to move() #948

Closed
wants to merge 5 commits into from
Closed

Allow passing undefined options to move() #948

wants to merge 5 commits into from

Commits on Mar 16, 2022

  1. Allow passing undefined options to move()

    @Nokel81
    Nokel81 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    1567a79 View commit details
    Browse the repository at this point in the history

  2. remove semicolon

    @RyanZim
    RyanZim committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    d148069 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Fix code to pass existing tests, add test to cover use case 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    9ff55e9 View commit details
    Browse the repository at this point in the history

  2. fix test not failing on throw of TypeError 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    ee3697a View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. Validate inputs to move 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    455d6cd View commit details
    Browse the repository at this point in the history