Skip to content

Commit

Permalink
[Makefile] remove worker prerequisite from test_image
Browse files Browse the repository at this point in the history
This is kinda revert of 1a22195 because now we rebuild
worker and test_image everytime we run check_in_container.

README does not need to be updated:
https://github.com/packit/packit-service/blob/master/CONTRIBUTING.md#running-tests-locally
  • Loading branch information
jpopelka committed Dec 16, 2020
1 parent b758dc9 commit 8aa0eb2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion Makefile
Expand Up @@ -32,9 +32,12 @@ check:
find . -name "*.pyc" -exec rm {} \;
PYTHONPATH=$(CURDIR) PYTHONDONTWRITEBYTECODE=1 python3 -m pytest --color=$(COLOR) --verbose --showlocals --cov=packit_service --cov-report=$(COV_REPORT) $(TEST_TARGET)

test_image: worker files/install-deps.yaml files/recipe-tests.yaml
# first run 'make worker'
test_image: files/install-deps.yaml files/recipe-tests.yaml
$(CONTAINER_ENGINE) build --rm -t $(TEST_IMAGE) -f files/docker/Dockerfile.tests --build-arg SOURCE_BRANCH=$(SOURCE_BRANCH) .

# If you haven't run this for some time, run 'make worker' first.
# 'worker' is not a dependency here because we don't want to rebuild images everytime.
check_in_container: test_image
@# don't use -ti here in CI, TTY is not allocated in zuul
echo $(SOURCE_BRANCH)
Expand Down

0 comments on commit 8aa0eb2

Please sign in to comment.