Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pydantic.PositiveFloat and subclasses for primitives in general #24

Merged
merged 4 commits into from Oct 3, 2022

Conversation

faph
Copy link
Contributor

@faph faph commented Sep 30, 2022

See issue #23

BTW, Why is there a max recursion error here?

@faph faph self-assigned this Sep 30, 2022
@faph faph changed the title [WIP] Test to reproduce lack of support for pydantic.PositiveFloat [WIP] support for pydantic.PositiveFloat and subclasses for primitives in general Sep 30, 2022
@faph
Copy link
Contributor Author

faph commented Sep 30, 2022

The max recursion error is coming from a Pydantic change with regards to forward refs. Need to debug.

Possibly as a result of pydantic/pydantic#4249. Using field.annotations instead.

@faph faph requested a review from jcameron73 October 1, 2022 09:26
@faph faph changed the title [WIP] support for pydantic.PositiveFloat and subclasses for primitives in general Support for pydantic.PositiveFloat and subclasses for primitives in general Oct 1, 2022
@faph faph added the enhancement New feature or request label Oct 1, 2022
@faph faph linked an issue Oct 1, 2022 that may be closed by this pull request
@faph faph merged commit 38c4e62 into main Oct 3, 2022
@faph faph deleted the feature/pydantic-positive-float branch October 3, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PositiveFloat is not supported
2 participants