New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: process with plugin raw svg #117
base: main
Are you sure you want to change the base?
Conversation
Hi, thanks for your PR! Could you add a Cypress test that shows the problem this PR solves? (That test should fail without your fix) |
when i used in webpack raw svgo loader
it responded me svg with plugins applied, but here i found that you just return raw text without processing. so i made it similar to webpack |
index.js
Outdated
@@ -1,5 +1,5 @@ | |||
const fs = require('fs').promises | |||
const { compileTemplate } = require('vue/compiler-sfc') | |||
const { compileTemplate } = require('@vue/compiler-sfc') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const { compileTemplate } = require('@vue/compiler-sfc') | |
const { compileTemplate } = require('vue/compiler-sfc') |
Thanks for your explanation. I understand it now! Can you fix my comment? Then i'll merge it |
@jpkleemans any progress on this? can you apply the change yourself? |
hi, i fixed your request, please reviw |
No description provided.