Tweaked jpeg-js library encoder to allow for RGB image data (rather than...

[emma-floored]

... assuming RGBA)

Now call with jpg.encode(imageData, quality, channels), channels defaults to 3.

[eugeneware]

Hi @emma-floored. Why was this closed. Did it break something?

[emma-floored]

@eugeneware It did, but I have fixed it now. When switching to a new project, I forgot to copy over some of my changes. I'm still new to git and didn't mean to make the pull request yet. Now that I have fixed my code I could open it again.

[eugeneware]

Thanks @emma-floored

I had a quick look, however, the tests (just run npm test when in the root dir) are failing.

If you could make the tests pass, and a few tests for some images with different numbers of channels that would be great.

[benwiley4000]

This has been discussed in #3 and it may be preferable to accept a number of image data formats for encoding (rgba, rgb, bgr, etc). Either way, since this library is widely used now it would be preferable not to change the default channel count.

As-is I don't think we can merge this PR, but @emma-floored if you're still interested in this sort of change we'd be happy to consider a new pull request, perhaps using the format discussed in #3! 🙂