Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limits on sampling factors #106

Merged
merged 2 commits into from Jun 3, 2022
Merged

Add limits on sampling factors #106

merged 2 commits into from Jun 3, 2022

Commits on Jun 2, 2022

  1. Add limits on sampling factors 

    Invalid sampling factors can lead to a divide by zero error
which could eventually lead to a infinite loop.

Also fixed failing tests + add a new test for invalid sampling
factors.

fixes #105
    @sohomdatta1
    sohomdatta1 committed Jun 2, 2022
    Copy the full SHA
    9b6325b View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Add explainer link and comment for sampling factor initialization

    @sohomdatta1
    sohomdatta1 committed Jun 3, 2022
    Copy the full SHA
    04cb2dc View commit details
    Browse the repository at this point in the history