Decode with PyJWK #886
Decode with PyJWK #886
Conversation
jwt/api_jwk.py
Outdated
| @@ -52,6 +52,7 @@ def __init__(self, jwk_data: JWKDict, algorithm: str | None = None) -> None: | |||
| if not has_crypto and algorithm in requires_cryptography: | |||
| raise PyJWKError(f"{algorithm} requires 'cryptography' to be installed.") | |||
|
|
|||
| self.algorithm = algorithm | |||
There was a problem hiding this comment.
Imo having both self.algorithm and self.Algorithm may be too similar
There was a problem hiding this comment.
Understandable. Any suggestions? self.algorithm_name? self.alg? (To match the JWK field)
There was a problem hiding this comment.
self.algorithm_name seems alright, actually I think self.Algorithm is the one being wrong, and self.algorithm_class or something similar might be better. Anyway better not breaking any public attribute
There was a problem hiding this comment.
I'm +1 on @Viicos's suggestion.
github-actions
bot
removed
the
stale
for more information, see https://pre-commit.ci
|
Ready for review 👍 |
|
restarted the CI, lets hope all are green |
There was a problem hiding this comment.
if not has_crypto and algorithm in requires_cryptography:
raise PyJWKError(f"{algorithm} requires 'cryptography' to be installed.")
E jwt.exceptions.PyJWKError: ES256 requires 'cryptography' to be installed.
jwt/api_jwk.py:53: PyJWKError
=========================== short test summary info ============================
SKIPPED [1] tests/test_advisory.py:27: Requires cryptography library installed
|
Okay, I fixed tests w/o cryptography installed. |
|
Ping. Any more feedback on this? @auvipy, it looks like you need to approve my changes. |
github-actions
bot
removed
the
stale
This PR contains three proposed changes. You can accept or reject any of them as you see fit. This is just a rough draft, once the functionality is approved I'll clean it up, add tests, and document.
Add
algorithmstring toPyJWK. This is useful in determine the appropriatealgorithmsvalue to pass intodecode().Allow a
PyJWKto be passed directly intodecode(), so it's not necessary to pullPyJWK.key. (This would fix Shouldjwt.decodeacceptPyJWKkeys? #864)If a
PyJWKis passed intodecode()andalgorithmsis not set, use the algorithm from the JWK. This change makes the API more convenient and reduces room for error: There's no reason that you should use any algorithm but the JWK's algorithm and doing otherwise is problematic at best and a possible security threat at worst.