Don't raise error when algorithm is not support #746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of raising an error for not supported algorithm we log the warning, and continue with other algorithms/keys
auvipy
requested changes
Apr 7, 2022
Added logging import
for more information, see https://pre-commit.ci
|
I'm off for the easter holydays without a computer, will look into it in a week. |
akx
suggested changes
Apr 11, 2022
Comment on lines
49
to
+56
| if not self.Algorithm: | ||
| raise PyJWKError("Unable to find a algorithm for key: %s" % self._jwk_data) | ||
| import logging | ||
|
|
||
| self.key = self.Algorithm.from_jwk(self._jwk_data) | ||
| self.key = None | ||
| logger = logging.getLogger(__name__) | ||
| logger.warning("Do not support algorithm %s", algorithm) | ||
| else: | ||
| self.key = self.Algorithm.from_jwk(self._jwk_data) |
There was a problem hiding this comment.
I think this might have security implications, as users of this class likely expect the algorithm in the JWK data to be valid.
|
Should be fixed with #762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of raising an error for not supported algorithm we log the warning, and continue with other algorithms/keys