Fix HEIC plate extraction by converting to JPEG before sending to openalpr #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalpr This adds about 6 seconds of latency since `heic-convert` is written in JS, but it's better than nothing. Maybe I can get `sharp` working at some point. Fixes #263
josephfrazier
temporarily deployed
to
github-heic-openalpr-6nzkvequb
josephfrazier
added a commit
that referenced
this pull request
Feb 11, 2021
This drops the latency from 6 seconds down to 1. However, it requires libheif and libvips to be installed, so I need to figure out how to do that on Heroku before this can be merged. On MacOS, this made it work (see lovell/sharp#2004 (comment)): ``` brew install libheif brew install libvips yarn remove sharp && yarn add sharp ``` Fixes #265: > See #264: > > > This adds about 6 seconds of latency since `heic-convert` is written in > > JS, but it's better than nothing. Maybe I can get `sharp` working at > > some point. > > Fixes #263: > > > Here's a test image [share.icloud.com/photos/0-5_Dy6WhkGw_7G-mlzadci-w#New_York](https://share.icloud.com/photos/0-5_Dy6WhkGw_7G-mlzadci-w#New_York) > > > I suspect openalpr doesn't support HEIC, and we might need to convert to JPG on the server before sending to openalpr, see [lovell/sharp#2004](lovell/sharp#2004) > > > If we can't get sharp working, try [npmjs.com/package/heic-convert](https://www.npmjs.com/package/heic-convert)
josephfrazier
added a commit
that referenced
this pull request
Feb 18, 2021
…from josephfrazier/remove.dead.heic.code * Revert "Disable HEIC to JPEG conversion due to OOM errors, see https://reportedcab.slack.com/archives/C9VNM3DL4/p1613245801038700?thread_ts=1610546281.002400&cid=C9VNM3DL4 (#270)" This reverts commit 4fd97e5. * Revert "Fix HEIC plate extraction by converting to JPEG before sending to openalpr (#264)" This reverts commit fc15cc4.
|
reverted in #275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds about 6 seconds of latency since
heic-convertis written inJS, but it's better than nothing. Maybe I can get
sharpworking atsome point.
Fixes #263: