Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace polyfill.io inside example #3167

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 1, 2024

The MathJax example uses polyfill.io. The PR replaces polyfill.io w/ cdnjs.cloudflare.com/polyfill.


polyfill.io was acquired by a China-based CDN company "Funnull", see the announcement from the polyfill.io domain owner's Twitter and https://github.com/polyfillpolyfill/polyfill-service/issues/2834. Despite Funnull's claims of operating in the United States, the predominance of Simplified Chinese on its website suggests otherwise, and it turns out that "Funnull" is notorious for providing service for the betting and pornography industries.

The original creator of the polyfill.io has voiced his concern on Twitter. And since the acquisition, numerous issues have emerged (polyfillpolyfill/polyfill-service#2835, polyfillpolyfill/polyfill-service#2838, alist-org/alist#6100), rendering the polyfill.io service extremely unstable. Since then, Fastly (Announcement) and Cloudflare (Announcement) has hosted their own instances of polyfill.io service.

@pkra
Copy link
Contributor

pkra commented Mar 1, 2024

FYI MathJax will likely do the same mathjax/MathJax-docs#334

@josdejong
Copy link
Owner

Thanks @SukkaW , that sounds like a good plan.

I think we can make it even simpler: just remove the line loading the ES6 polyfill, it is not needed anymore. What do you think?

@SukkaW
Copy link
Contributor Author

SukkaW commented Mar 8, 2024

I think we can make it even simpler: just remove the line loading the ES6 polyfill, it is not needed anymore. What do you think?

It is 2024 now, and 98% of browsers around the globe support ES6 (https://caniuse.com/es6). So yes, I agree to remove the polyfill altogether! Lemme rebase my PR real quick.


@josdejong I've rebased my PR and it is ready for review now!

@josdejong
Copy link
Owner

Awesome 😎 a PR that just removes one line and that's it 😄

Thanks Sukka!

@josdejong josdejong merged commit d5740c9 into josdejong:develop Mar 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants