Types/improve operator node types

[mattvague]

This PR adds generic op and fn args to OperatorNode type to solve the problems laid out here

Addresses #2575

[mattvague]

Also just added a generic arg for args so that the following works 😍

[mattvague]

I'm wondering now if I should make the op and fn generic args optional as this would be a breaking change otherwise. Thoughts @josdejong?

[josdejong]

Thanks, this makes sense.

I'm wondering now if I should make the op and fn generic args optional as this would be a breaking change otherwise. Thoughts @josdejong?

That is a good point. Are there drawbacks to making the generic arguments optional? If so, we can schedule this as a breaking change for v11.

[mattvague]

That is a good point. Are there drawbacks to making the generic arguments optional? If so, we can schedule this as a breaking change for v11.

Hmm, yeah actually now that I think of it I believe we couldn't do the fancy check that ensures a valid op and fn combo which I feel adds a lot of the value.

If so, we can schedule this as a breaking change for v11.

Should we leave this whole PR until then, or should I create "watered down" version for now where TOp and TFn are just strings?

[mattvague]

Ah, nevermind! I forgot you can just set the default as never. This means that they are optional, but if you do specify them then the combo has to be correct:

[josdejong]

Nice 🤩

[josdejong]

Published now in v10.6.1