Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative dividend modulo for BigNumber and Fraction #1973

Merged
merged 2 commits into from Sep 23, 2020
Merged

Fix negative dividend modulo for BigNumber and Fraction #1973

merged 2 commits into from Sep 23, 2020

Conversation

ovk
Copy link
Contributor

@ovk ovk commented Sep 22, 2020

This fixes incorrect mod behaviour for BigNumbers and Fractions, as described in issue #1964.

@josdejong
Copy link
Owner

Thanks @ovk 👍 , looks good.

@josdejong josdejong merged commit 36c53b7 into josdejong:develop Sep 23, 2020
@josdejong
Copy link
Owner

Published now in v7.3.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ovk @josdejong