Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for Toolbar and Context Menu plugins #438

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Implement support for Toolbar and Context Menu plugins #438

wants to merge 8 commits into from

Commits on Jul 18, 2017

  1. Implement toolbar plugins

    @dhughes-xumak
    dhughes-xumak committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    eb48486 View commit details
    Browse the repository at this point in the history

  2. Implement context menu plugins

    @dhughes-xumak
    dhughes-xumak committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    2a6a65e View commit details
    Browse the repository at this point in the history

  3. Create test for toolbar and context menu plugin support

    @dhughes-xumak
    dhughes-xumak committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    2dd41d7 View commit details
    Browse the repository at this point in the history

  4. Add a selectedElements parameter to ContextMenu to pass to actions' c… 

    …lick handlers.

This allows us to remove the ugly callback wrapping when processing the contextMenuPlugins.
Also updates test and documentation.
    @dhughes-xumak
    dhughes-xumak committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    a8e3ae9 View commit details
    Browse the repository at this point in the history

  5. Add contextMenuPlugin.submenuTitle to docs and test. 

    I noticed that the arrow only renders properly in some cases.  For this reason, the submenuTitle only works sometimes.
    @dhughes-xumak
    dhughes-xumak committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    fbd082d View commit details
    Browse the repository at this point in the history

  6. Add contextMenuPlugin.enabled property so plugins can enable/disabl… 

    …e themselves.

Includes docs and tests.

In the future, it may be preferable for disabled actions to be constructed and appear in
the context menu, appearing as disabled (grayed out).
    @dhughes-xumak
    dhughes-xumak committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    f33365d View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2017

  1. Add class to plugin actions for setting default icons

    @dhughes-xumak
    dhughes-xumak committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    bde68cf View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2017

  1. Merge branch 'develop' into feature/toolbar-and-contextmenu-plugins

    @dhughes-xumak
    dhughes-xumak committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    231ab37 View commit details
    Browse the repository at this point in the history