384 linter

.eslintignore

@@ -0,0 +1,9 @@
+dist/
+docs/
+examples/
+misc/
+test/
+gulpfile.js
+index.js
+/src/js/ace/**/*.*
+/src/js/assets/**/*.*

.eslintrc

@@ -0,0 +1,25 @@
+{
+  "env": {
+    "browser": true
+  },
+  "plugins": [],
+  "rules": {
+    "strict": 0,
+    "indent": ["error", 2, { "SwitchCase": 1, "VariableDeclarator": 2 }],
+    "semi": ["error", "always"],
+    "semi-spacing": ["error", {"before": false, "after": true}],
+    "no-extra-semi": 2,
+    "no-trailing-spaces": 1,
+    //"max-len": ["error", 80]
+    "quotes": ["error", "single"],
+    "brace-style": ["error", "stroustrup", { "allowSingleLine": true }],
+    "one-var": ["error", { "var": "never" }],
+    "camelcase": "error",
+    "new-cap": ["error", { "capIsNewExceptions": ["Ajv"] }],
+    "quote-props": ["error", "as-needed"],
+    "comma-style": ["error", "last"],
+    //"eqeqeq": "error",
+    "no-extend-native": "error"
+    //"max-statements": ["error", 10]
+  }
+}

.gitignore

@@ -3,4 +3,5 @@ build
 downloads
 node_modules
 *.zip
-npm-debug.log
+npm-debug.log
+.eslintcache

package.json

@@ -20,14 +20,16 @@
   "scripts": {
     "build": "gulp",
     "watch": "gulp watch",
-    "test": "mocha test"
+    "test": "mocha test",
+    "lint": "eslint -c .eslintrc --cache ."
   },
   "dependencies": {
     "ajv": "4.11.6",
     "brace": "0.10.0",
     "javascript-natural-sort": "0.7.1"
   },
   "devDependencies": {
+    "eslint": "^3.19.0",
     "gulp": "3.9.1",
     "gulp-clean-css": "3.0.4",
     "gulp-concat-css": "2.3.0",

src/js/ContextMenu.js

@@ -339,7 +339,10 @@ ContextMenu.prototype._onKeyDown = function (event) {
   var target = event.target;
   var keynum = event.which;
   var handled = false;
-  var buttons, targetIndex, prevButton, nextButton;
+  var buttons;
+  var targetIndex;
+  var prevButton;
+  var nextButton;
 
   if (keynum == 27) { // ESC
     // hide the menu on ESC key

src/js/History.js

@@ -16,119 +16,119 @@ function History (editor) {
 
   // map with all supported actions
   this.actions = {
-    'editField': {
-      'undo': function (params) {
+    editField: {
+      undo: function (params) {
         params.node.updateField(params.oldValue);
       },
-      'redo': function (params) {
+      redo: function (params) {
         params.node.updateField(params.newValue);
       }
     },
-    'editValue': {
-      'undo': function (params) {
+    editValue: {
+      undo: function (params) {
         params.node.updateValue(params.oldValue);
       },
-      'redo': function (params) {
+      redo: function (params) {
         params.node.updateValue(params.newValue);
       }
     },
-    'changeType': {
-      'undo': function (params) {
+    changeType: {
+      undo: function (params) {
         params.node.changeType(params.oldType);
       },
-      'redo': function (params) {
+      redo: function (params) {
         params.node.changeType(params.newType);
       }
     },
 
-    'appendNodes': {
-      'undo': function (params) {
+    appendNodes: {
+      undo: function (params) {
         params.nodes.forEach(function (node) {
           params.parent.removeChild(node);
         });
       },
-      'redo': function (params) {
+      redo: function (params) {
         params.nodes.forEach(function (node) {
           params.parent.appendChild(node);
         });
       }
     },
-    'insertBeforeNodes': {
-      'undo': function (params) {
+    insertBeforeNodes: {
+      undo: function (params) {
         params.nodes.forEach(function (node) {
           params.parent.removeChild(node);
         });
       },
-      'redo': function (params) {
+      redo: function (params) {
         params.nodes.forEach(function (node) {
           params.parent.insertBefore(node, params.beforeNode);
         });
       }
     },
-    'insertAfterNodes': {
-      'undo': function (params) {
+    insertAfterNodes: {
+      undo: function (params) {
         params.nodes.forEach(function (node) {
           params.parent.removeChild(node);
         });
       },
-      'redo': function (params) {
+      redo: function (params) {
         var afterNode = params.afterNode;
         params.nodes.forEach(function (node) {
           params.parent.insertAfter(params.node, afterNode);
           afterNode = node;
         });
       }
     },
-    'removeNodes': {
-      'undo': function (params) {
+    removeNodes: {
+      undo: function (params) {
         var parent = params.parent;
         var beforeNode = parent.childs[params.index] || parent.append;
         params.nodes.forEach(function (node) {
           parent.insertBefore(node, beforeNode);
         });
       },
-      'redo': function (params) {
+      redo: function (params) {
         params.nodes.forEach(function (node) {
           params.parent.removeChild(node);
         });
       }
     },
-    'duplicateNodes': {
-      'undo': function (params) {
+    duplicateNodes: {
+      undo: function (params) {
         params.nodes.forEach(function (node) {
           params.parent.removeChild(node);
         });
       },
-      'redo': function (params) {
+      redo: function (params) {
         var afterNode = params.afterNode;
         params.nodes.forEach(function (node) {
           params.parent.insertAfter(node, afterNode);
           afterNode = node;
         });
       }
     },
-    'moveNodes': {
-      'undo': function (params) {
+    moveNodes: {
+      undo: function (params) {
         params.nodes.forEach(function (node) {
           params.oldBeforeNode.parent.moveBefore(node, params.oldBeforeNode);
         });
       },
-      'redo': function (params) {
+      redo: function (params) {
         params.nodes.forEach(function (node) {
           params.newBeforeNode.parent.moveBefore(node, params.newBeforeNode);
         });
       }
     },
 
-    'sort': {
-      'undo': function (params) {
+    sort: {
+      undo: function (params) {
         var node = params.node;
         node.hideChilds();
         node.sort = params.oldSort;
         node.childs = params.oldChilds;
         node.showChilds();
       },
-      'redo': function (params) {
+      redo: function (params) {
         var node = params.node;
         node.hideChilds();
         node.sort = params.newSort;
@@ -162,9 +162,9 @@ History.prototype.onChange = function () {};
 History.prototype.add = function (action, params) {
   this.index++;
   this.history[this.index] = {
-    'action': action,
-    'params': params,
-    'timestamp': new Date()
+    action: action,
+    params: params,
+    timestamp: new Date()
   };
 
   // remove redo actions which are invalid now

src/js/JSONEditor.js

@@ -344,7 +344,8 @@ JSONEditor.prototype.refresh = function () {
  * @param {Object | Array} mode  A mode object or an array with multiple mode objects.
  */
 JSONEditor.registerMode = function (mode) {
-  var i, prop;
+  var i;
+  var prop;
 
   if (util.isArray(mode)) {
     // multiple modes

src/js/ModeSwitcher.js

@@ -14,37 +14,37 @@ function ModeSwitcher(container, modes, current, onSwitch) {
   // available modes
   var availableModes = {
     code: {
-      'text': 'Code',
-      'title': 'Switch to code highlighter',
-      'click': function () {
-        onSwitch('code')
+      text: 'Code',
+      title: 'Switch to code highlighter',
+      click: function () {
+        onSwitch('code');
       }
     },
     form: {
-      'text': 'Form',
-      'title': 'Switch to form editor',
-      'click': function () {
+      text: 'Form',
+      title: 'Switch to form editor',
+      click: function () {
         onSwitch('form');
       }
     },
     text: {
-      'text': 'Text',
-      'title': 'Switch to plain text editor',
-      'click': function () {
+      text: 'Text',
+      title: 'Switch to plain text editor',
+      click: function () {
         onSwitch('text');
       }
     },
     tree: {
-      'text': 'Tree',
-      'title': 'Switch to tree editor',
-      'click': function () {
+      text: 'Tree',
+      title: 'Switch to tree editor',
+      click: function () {
         onSwitch('tree');
       }
     },
     view: {
-      'text': 'View',
-      'title': 'Switch to tree view',
-      'click': function () {
+      text: 'View',
+      title: 'Switch to tree view',
+      click: function () {
         onSwitch('view');
       }
     }