Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Removed from_data from all arrays #1328

Merged
merged 1 commit into from Dec 15, 2022
Merged

Removed from_data from all arrays #1328

merged 1 commit into from Dec 15, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Dec 13, 2022

This function is a very old artifact from ArrayData and has been superseded by either new or try_new, which are more idiomatic.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 83.13% // Head: 83.08% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (53d519d) compared to base (96cafcf).
Patch coverage: 75.09% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
- Coverage   83.13%   83.08%   -0.06%     
==========================================
  Files         370      370              
  Lines       40282    40170     -112     
==========================================
- Hits        33488    33374     -114     
- Misses       6794     6796       +2     
Impacted Files Coverage Δ
src/array/binary/mutable_values.rs 76.09% <0.00%> (-0.38%) ⬇️
src/array/fixed_size_binary/mod.rs 85.02% <ø> (+1.34%) ⬆️
src/array/fixed_size_list/mod.rs 85.89% <ø> (+3.68%) ⬆️
src/array/map/mod.rs 61.22% <ø> (+3.15%) ⬆️
src/array/null.rs 52.56% <ø> (-1.76%) ⬇️
src/array/struct_/mod.rs 60.11% <ø> (-1.56%) ⬇️
src/array/union/mod.rs 76.55% <ø> (-0.87%) ⬇️
src/io/odbc/read/deserialize.rs 0.00% <0.00%> (ø)
src/array/fixed_size_list/mutable.rs 70.92% <50.00%> (-0.31%) ⬇️
src/array/growable/binary.rs 95.16% <50.00%> (ø)
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao marked this pull request as ready for review December 15, 2022 05:42
@jorgecarleitao jorgecarleitao merged commit df95803 into main Dec 15, 2022
@jorgecarleitao jorgecarleitao deleted the rm_from_data branch December 15, 2022 05:55
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant