Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for Extension types in ffi #1300

Merged

Conversation

jondo2010
Copy link
Contributor

Some nestings of Extension and Struct types need additional support in the ffi Schema handling.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 83.06% // Head: 83.11% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (f55295a) compared to base (2fa401b).
Patch coverage: 93.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
+ Coverage   83.06%   83.11%   +0.05%     
==========================================
  Files         361      369       +8     
  Lines       38370    40175    +1805     
==========================================
+ Hits        31872    33392    +1520     
- Misses       6498     6783     +285     
Impacted Files Coverage Δ
src/ffi/schema.rs 90.08% <93.75%> (-0.30%) ⬇️
src/array/list/iterator.rs 32.14% <0.00%> (-35.30%) ⬇️
src/array/binary/iterator.rs 75.00% <0.00%> (-25.00%) ⬇️
src/array/equal/struct_.rs 46.34% <0.00%> (-24.40%) ⬇️
src/array/fixed_size_binary/iterator.rs 72.72% <0.00%> (-8.53%) ⬇️
src/array/binary/mutable.rs 78.36% <0.00%> (-5.85%) ⬇️
src/array/fixed_size_binary/mod.rs 83.68% <0.00%> (-3.82%) ⬇️
src/array/mod.rs 64.93% <0.00%> (-3.62%) ⬇️
src/array/struct_/iterator.rs 52.94% <0.00%> (-2.62%) ⬇️
src/io/json/read/infer_schema.rs 93.15% <0.00%> (-2.33%) ⬇️
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jondo2010
Copy link
Contributor Author

Clippy errors should be fixed now

@jorgecarleitao jorgecarleitao changed the title Fix for supporting Extension types in ffi Added support for Extension types in ffi Nov 23, 2022
@jorgecarleitao jorgecarleitao merged commit f13fbe3 into jorgecarleitao:main Nov 23, 2022
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants