This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Upgrade to ahash v0.8 #1271
Merged
Upgrade to ahash v0.8 #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This broke main and I missed it somehow when approving :/ |
jorgecarleitao
added a commit
that referenced
this pull request
Oct 14, 2022
This reverts commit 7cd8c49.
|
I just reverted this until we can fix it - see #1274 |
|
Thanks for being so on top of it! #1274 seems to have passed tests, unlike this PR! Anything you need me to do? |
|
We need to fix the #1274 - it is failing to compile on wasm32 |
benesch
added a commit
to benesch/arrow2
that referenced
this pull request
Nov 13, 2022
This is a resubmission of jorgecarleitao#1271, which was reverted in 6e46651, due to compilation errors with the wasm32 target. It builds on jorgecarleitao#1274 to fix those compilation errors. Closes jorgecarleitao#1274.
benesch
added a commit
to benesch/arrow2
that referenced
this pull request
Nov 13, 2022
This is a resubmission of jorgecarleitao#1271, which was reverted in 6e46651, due to compilation errors with the wasm32 target. It builds on jorgecarleitao#1274 to fix those compilation errors. Closes jorgecarleitao#1274. Co-authored-by: "Jorge C. Leitao" <jorgecarleitao@gmail.com>
Merged
benesch
added a commit
to benesch/arrow2
that referenced
this pull request
Nov 13, 2022
This is a resubmission of jorgecarleitao#1271, which was reverted in 6e46651, due to compilation errors with the wasm32 target. It builds on jorgecarleitao#1274 to fix those compilation errors. Closes jorgecarleitao#1274. Co-authored-by: "Jorge C. Leitao" <jorgecarleitao@gmail.com>
benesch
added a commit
to benesch/arrow2
that referenced
this pull request
Nov 13, 2022
This is a resubmission of jorgecarleitao#1271, which was reverted in 6e46651, due to compilation errors with the wasm32 target. It builds on jorgecarleitao#1274 to fix those compilation errors. Closes jorgecarleitao#1274. Co-authored-by: "Jorge C. Leitao" <jorgecarleitao@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @jorgecarleitao! Just looking to avoid a duplicate dependency downstream, and this looked to drop in easily.