Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GDScript Parser Suggestions #2

Closed
wants to merge 1,386 commits into from
Closed

Add GDScript Parser Suggestions #2

wants to merge 1,386 commits into from

Conversation

jordigcs
Copy link
Owner

@jordigcs jordigcs commented Apr 6, 2022

Relies on godotengine#59943
Implementation of godotengine/godot-proposals#4310

Adds "suggestions" to the GDScript Parser that enforce the GDScript Style Guide.

Suggestions

  • Naming Conventions

image

  • Trailing Commas

image

  • Unecessary Parenthesis

image

akien-mga and others added 30 commits March 10, 2022 18:10
…_and_events

Adding signals and events to OpenXR interface
Done via making the function more robust to different inputs
…-torus

Fix normals computation at the 'seam' of smoothed torus shape
Remove unused code in `AnimationPlayerEditor::_update_animation_list_icons()`
…rrences

Remove more occurrences of "stex"
…ise_openxr_if_initialised

Only uninitialise OpenXR on destruct if it was initialized
`DirAccess *` needs to be deleted manually, and this is often forgotten
especially when doing early returns with `ERR_FAIL_COND`.
`DirAccessRef` is deleted automatically when it goes out of scope.

Co-authored-by: bruvzg <7645683+bruvzg@users.noreply.github.com>
…elineEdit

get_cursor_shape() is used in cases where a Control displays different cursors in different areas.
There is no need to set the default cursor shape on every mouse move event.
…ckEditTypeAudio

get_cursor_shape() is used in cases where a Control displays different cursors in different areas.
There is no need to set the default cursor shape on every mouse move event.
…eStateMachineEditor

get_cursor_shape() is used in cases where a Control displays different cursors in different areas.
There is no need to set the default cursor shape on every mouse move event.

Fix minor issue with selection order.
Use `RTR()` for `VisualScriptNode` captions and texts
Clarify the position of points in `Curve{2D,3D}.add_point()`
…mals-computation

Fix mixed smoothed and non-smoothed face normals computation for CSG shapes
akien-mga and others added 27 commits March 19, 2022 18:09
Ensure minimum modifiers are pressed when matching actions
Advanced import settings inspector is cleared when opened
…_global

Raycasts hitting from inside: return collision point in global coordinates
…exture_free

Call the correct texture free method on texture storage cleanup
More editor `extract.py` improvements and fixes
HTTPClientTCP expects proxy host to be empty or port to be -1 to ignore
the proxy. When getting the proxy config from the settings file, the
values will default to U"null" and 0, respectively, making HTTPClientTCP
to attempt to use the values as a proxy, which causes getaddrinfo to
fail looking up a "null" hostname.

Setting the default config values seems like a good approach to prevent
this issue.

Fixes godotengine#59037
…ong_it_pushes_the_inspector

Reduce the size of Controls editor toolbar
…extension

Document the MultiplayerPeerExtension class
This moves the setting in question to the bottom of the Editor Settings,
which makes it less likely to be accidentally enabled.
This brings the level of line spacing closer to what it was like
in Godot 3.x, which improves usability on small displays.

This also decreases the default line spacing for fixed-width texts
in the About dialog (license text).
…nfo-failed

Fix getaddrinfo failed with undefined proxy config
…zation-move-setting

Move the pseudolocalization editor setting to a debug section
…ase-line-spacing

Decrease the default line spacing in the script editor
[Editor] Fix reloading editor theme on font / font size setting change.
@jordigcs jordigcs closed this Apr 6, 2022
@jordigcs jordigcs deleted the parser_suggestions branch April 28, 2022 16:02
jordigcs pushed a commit that referenced this pull request Aug 13, 2022
[doc] Use "param" instead of "code" to refer to parameters #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet