Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs} Remove target-specific options from general options #2047

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaronliu0130
Copy link

These are later duplicated in their own sections and clog up the list of general options.

@jordansissel
Copy link
Owner

Ahh, I think I see what happens here - thank you for this improvement!

This file is generated by the documentation building process, so modifying this file directly won't survive very long.

I did a little bit of digging and found this - The docs generator iterates over every flag for the general options. However, this class (FPM::Command) adds all package flags to itself on startup.

To fix this, maybe having the docs generator skip any package-specific flags for the 'general' section. One way may be to check if the flag's "help" text includes something like (deb only) at the beginning as all package-specific flags will do this. https://github.com/jordansissel/fpm/blob/main/lib/fpm/package.rb#L439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants