Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in deb.rb outputting erroneous conffiles file when specifying upstart config #1984

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NicholasBHubbard
Copy link
Contributor

@NicholasBHubbard NicholasBHubbard commented Jan 9, 2023

This PR fixes a bug in deb.rb where adding an upstart configuration file via the --deb-upstart flag, causes FPM to output a deb package with an erroneous conffiles file.

Steps to reproduce:

$ cd $FPM_ROOT
$ touch /tmp/foo.upstart
$ bundle exec fpm -t deb -s cpan --deb-upstart /tmp/foo.upstart -p /tmp/perl-file-temp_VERSION_all.deb --log error File::Temp
Created package {:path=>"/tmp/perl-file-temp_0.2311_all.deb"}
$ cd /tmp
$ ar x perl-file-temp_0.2311_all.deb
$ tar -xf control.tar.gz
$ cat conffiles
/etc/init/foo.conf
/tc/init/foo.conf

This example shows that the conffiles file erroneously contains the value /tc/init/foo.conf.

With the fix from this PR the conffiles file contains only /etc/init/foo.conf.

@wbraswell
Copy link
Contributor

This PR looks good to me!
@jordansissel, we realize that you may still be busy taking care of your family, please take a look when you get a chance, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants