Added undefined check #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE11 and below doesn’t support the name property of the constructor object, so put in a check to avoid exceptions when slice() method is called.
tunnckoCore
reviewed
Aug 2, 2017
| @@ -29,7 +29,7 @@ module.exports = function kindOf(val) { | |||
|
|
|||
| // functions | |||
| if (type === 'function' || val instanceof Function) { | |||
| if (val.constructor.name.slice(0, 9) === 'Generator') { | |||
| if (typeof val.constructor.name !== 'undefined' && val.constructor.name.slice(0, 9) === 'Generator') { | |||
There was a problem hiding this comment.
when so much bytes is used, it's probably better to directly be checking of string.
So:
var name = (val.constructor && val.constructor.name) || ''
if (name && name.length && name.slice(0, 9) === 'Generator') {There was a problem hiding this comment.
initially, i just meant that if (typeof val.constructor.name === 'string' && would be better, but later update my thought :D
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 and below doesn’t support the name property of the constructor
object, so put in a check to avoid exceptions when slice() method is
called.