Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined check missing in 5.0.0/5.0.1 #13

Closed
struct78 opened this issue Aug 1, 2017 · 3 comments
Closed

Undefined check missing in 5.0.0/5.0.1 #13

struct78 opened this issue Aug 1, 2017 · 3 comments

Comments

@struct78
Copy link

struct78 commented Aug 1, 2017 •
edited

Hi,

This line requires an undefined check, the constructor's name property is undefined in IE11 and lower so it throws an exception when trying to call the slice method.

https://github.com/jonschlinkert/kind-of/blob/master/index.js#L32
@jonschlinkert
Copy link
Owner

want to do a pr?

@struct78
Copy link
Author

struct78 commented Aug 2, 2017

Done #14

@struct78 struct78 changed the title Null check missing in 5.0.0/5.0.1 Null/undefined check missing in 5.0.0/5.0.1 Aug 2, 2017
@struct78 struct78 changed the title Null/undefined check missing in 5.0.0/5.0.1 Undefined check missing in 5.0.0/5.0.1 Aug 2, 2017
@jonschlinkert
Copy link
Owner

forgot to close this, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonschlinkert @struct78