Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support MemberExpression.optional #2

Merged

Conversation

6utt3rfly
Copy link
Contributor

Add support for MemberExpression.optional (but leave support for non-standard OptionalMemberExpression type)

see estree/estree#204

@jonschlinkert jonschlinkert merged commit d16de18 into jonschlinkert:main Sep 26, 2021
@jonschlinkert
Copy link
Owner

thanks, this is great!

@6utt3rfly
Copy link
Contributor Author

Thank you! And it's a very well done project. I wasn't sure about the expressionAsync changes, but I just copied from the OptionalMemberExpression method which seemed safe enough 🤷🏻‍♀️.

I was testing with the jsep package and found only a few discrepancies (like BigInt support), but I like this project 😊

@jonschlinkert
Copy link
Owner

it's a very well done project.

thanks! I tried to put a lot of thought into it, I'm glad you like it, thanks!

like BigInt support

I thought we had BigInt support here. or do you mean on jsep? Anything we need to fix?

thanks again!

@6utt3rfly 6utt3rfly deleted the fix/member-expr-optional branch September 29, 2021 15:19
@6utt3rfly
Copy link
Contributor Author

BigInt support here. or do you mean on jsep? Anything we need to fix?

Sorry for being unclear. I meant that jsep doesn't yet have BigInt support

@jonschlinkert
Copy link
Owner

jonschlinkert commented Sep 29, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants