New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependendies (ahash, quick-xml) #258
Conversation
dd26f00
to
23a5ff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks for taking the time!
Unfortunately, it looks like some of the CI jobs fail 🤔 I'm guessing some of the formatting from Separately, I noticed that |
13d2a1a
to
5e75305
Compare
Working on it (probably needs a few iterations because I cannot get the tests to run locally (the Update: I found out why my local tests don't pass, git submodules FTW 😅 |
5e75305
to
84eeeb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you!
Codecov ReportBase: 90.33% // Head: 90.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 90.33% 90.29% -0.04%
==========================================
Files 19 19
Lines 4241 4226 -15
==========================================
- Hits 3831 3816 -15
Misses 410 410
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Looks like we have a couple of CI failures:
|
39b6194
to
9efd94a
Compare
This is now solely blocked by the quick-xml release. |
We should also do a bump of clap to major version 4, but I suppose it's no rush (and can be done in a separate PR). |
56cfc71
to
bb01949
Compare
Updated to quick-xml 0.26 -- which fixes the MSRV. Let's do clap in another PR, also because this would mean that we compile two version of clap (at least for testing) because criterion still uses V3. |
Ah, forgot the changelog! Would you mind updating that too? |
#273. |
Hey 👋
We're using your nice crate over at https://github.com/influxdata/influxdb_iox (indirectly via
pprof
) and I've seen that some of our the dependencies thatinferno
pulls are slightly outdated and hence get compiled twice. So I've decided to update them. 🙂