Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bottom blank line #388

Merged
merged 2 commits into from Jul 17, 2022
Merged

Add bottom blank line #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11d5fe8
Add bottom blank line
mihiron Jul 15, 2022
7205a99
Merge branch 'master' into feature/add_bottom_blank_line
jonbhanson Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/android.dart
View file
Open in desktop
Expand Up @@ -298,7 +298,7 @@ void _applyLaunchBackgroundXml({
}

launchBackgroundFile.writeAsStringSync(
launchBackgroundDocument.toXmlString(pretty: true, indent: ' '),
'${launchBackgroundDocument.toXmlString(pretty: true, indent: ' ')}\n',
);
}

Expand Down Expand Up @@ -429,7 +429,7 @@ Future<void> _updateStylesFile({
}

stylesFile.writeAsStringSync(
stylesDocument.toXmlString(pretty: true, indent: ' '),
'${stylesDocument.toXmlString(pretty: true, indent: ' ')}\n',
);
}

Expand Down
8 changes: 6 additions & 2 deletions lib/ios.dart
View file
Open in desktop
Expand Up @@ -387,7 +387,9 @@ void _updateLaunchScreenStoryboard({
}
}

file.writeAsStringSync(xmlDocument.toXmlString(pretty: true, indent: ' '));
file.writeAsStringSync(
'${xmlDocument.toXmlString(pretty: true, indent: ' ')}\n',
);
}

/// Creates LaunchScreen.storyboard with splash image path
Expand Down Expand Up @@ -556,5 +558,7 @@ void _updateInfoPlistFile({
}
}

file.writeAsStringSync(xmlDocument.toXmlString(pretty: true, indent: ' '));
file.writeAsStringSync(
'${xmlDocument.toXmlString(pretty: true, indent: ' ')}\n',
);
}
3 changes: 1 addition & 2 deletions lib/web.dart
View file
Open in desktop
Expand Up @@ -282,7 +282,6 @@ void updateIndex({
);
}
}

if (existingBrandingPictureLine == 0) {
if (brandingImagePath != null) {
for (var x = _indexHtmlBrandingPicture.length - 1; x >= 0; x--) {
Expand All @@ -303,5 +302,5 @@ void updateIndex({
);
}
}
webIndex.writeAsStringSync(lines.join('\n'));
webIndex.writeAsStringSync('${lines.join('\n')}\n');
}