Merge pull request rubocop#9705 from koic/fix_an_error_for_style_sing…

…le_line_method Fix an error for `Style/SingleLineMethods`
jonas054 · Apr 17, 2021 · 7d12a8d · 7d12a8d
2 parents f504a4e + 42e9d89
commit 7d12a8d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rubocop/cop/style/single_line_methods.rb b/lib/rubocop/cop/style/single_line_methods.rb
@@ -115,7 +115,7 @@ def move_comment(node, corrector)
         end
 
         def method_body_source(method_body)
-          if method_body.arguments.empty? || method_body.parenthesized?
+          if !method_body.send_type? || method_body.arguments.empty? || method_body.parenthesized?
             method_body.source
           else
             arguments_source = method_body.arguments.map(&:source).join(', ')

diff --git a/spec/rubocop/cop/style/single_line_methods_spec.rb b/spec/rubocop/cop/style/single_line_methods_spec.rb
@@ -187,6 +187,12 @@ def some_method(a, b, c) = body
         RUBY
       end
 
+      it 'corrects to an endless method definition when method body is a literal' do
+        expect_correction(<<~RUBY.strip, source: 'def some_method; 42 end')
+          def some_method() = 42
+        RUBY
+      end
+
       it 'corrects to an endless method definition when single line method call with parentheses' do
         expect_correction(<<~RUBY.strip, source: 'def index() head(:ok) end')
           def index() = head(:ok)