Migrate away from PHPUnit's expectedException annotations #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mszabo-wikia This branch has conflicts (due to #85) that must be resolved. Could you please rebase |
PHPUnit provides expectedException and related annotations to declaratively specify information about the exception a test is expected to throw. This API has been deprecated in PHPUnit 8 and is due to be removed in PHPUnit 9.[1] This patch migrates the tests to use the recommended expectException() and related methods instead of the annotations to ensure that a future PHPUnit upgrade will not break them. --- [1] sebastianbergmann/phpunit#3332
|
Thanks! Rebased :) |
sergeyklay
approved these changes
Mar 16, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit provides expectedException and related annotations to
declaratively specify information about the exception a test
is expected to throw. This API has been deprecated in PHPUnit 8
and is due to be removed in PHPUnit 9.[1]
This patch migrates the tests to use the recommended expectException()
and related methods instead of the annotations to ensure that a future
PHPUnit upgrade will not break them.
[1] sebastianbergmann/phpunit#3332