Add experimental support for Symfony Messenger #16
Conversation
| $model = $this->fetchModel($message->getType(), $message->getId()); | ||
|
|
||
| if (!$model) { | ||
| // ID does not exists, delete |
There was a problem hiding this comment.
To me, if fetchModel fail to found the entity/the data, that means it does not exists. If it did exists before, triggering a delete is a safe way to sync the fetchModel behavior with what we have in Elasticsearch.
There was a problem hiding this comment.
But if the does not exist, if you delete it you basically delete nothing.
|
I just pushed a better version and the documentation. There this a "MultipleIndexationRequest" message now, and a listener to group single messages in this one, allowing spool / bulk of all the changes into one message! |
Conflicts: README.md composer.json
|
The pooling feature is tested successfully on a real world project 🎉 |
Co-Authored-By: Loïck Piera <pyrech@gmail.com>
| $this->schedule($indexer, $message); | ||
| } | ||
|
|
||
| $indexer->flush(); |
There was a problem hiding this comment.
Could we check for errors, then requeue the MultipleIndexationRequest (or IndexationRequest) only with those that have failed?
There was a problem hiding this comment.
With Messenger, any Exception is gonna re-queue the entire message.
In the case of Elasticsearch indexing, a bulk can fail only for one doc, and the other docs will be OK in the index (no rollback). I like the idea but it means we should edit the message that's being "re-queue"; I don't know how to do that yet :)
There was a problem hiding this comment.
I tried to implement it here: #18
Symfony Messenger is really simple to use. In this pull request I just add the basic of handling indexation request via Messenger.
There is a simple DTO, the provided handler must be overwritten to implement the fetchModel method, then I call the proper methods on the Indexer.
I use a very close version of this in production already 😋