New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the Messenger Handler, improve the "NullLogger" situation #17

Open

damienalexandre opened this issue Jan 16, 2020 · 1 comment

Labels

enhancement Hacktoberfest

Member

damienalexandre commented Jan 16, 2020

We remove the Elastica Logger in the Message Handler for memory / perf considerations:

    public function __construct(Client $client)
    {
        $this->client = $client;

        // Disable the logs for memory concerns
        $this->client->setLogger(new NullLogger());
    }

But that's not ideal as I removed forever, also for calls outside the Handler.

We have to find a better way, or a better logger than Elastica built in.

damienalexandre added the enhancement label

damienalexandre mentioned this issue

Add experimental support for Symfony Messenger #16

Merged

Member

lyrixx commented Jan 16, 2020 •

edited

Some hint for the resolution:

Use a well configured (logger channel & co) client if not defined : Use an HttpClient without logger in all handlers symfony/monolog-bundle#331
Maybe remove the logger in CLI [Monolog] Disable DebugLogger in CLI symfony/symfony#30339

damienalexandre added the Hacktoberfest label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment