Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated auto_terminate option #52

Merged
merged 1 commit into from Dec 20, 2023

Conversation

itkrt2y
Copy link
Contributor

@itkrt2y itkrt2y commented Dec 20, 2023

Due to the change in ruby-concurrency/concurrent-ruby#841, the auto_terminate option has become deprecated, and specifying it has no effect.
Since the default value of this is true, I simply removed it.

WARN -- Concurrent::CachedThreadPool: [DEPRECATED] Method #auto_terminate= has no effect. Set :auto_terminate option when executor is initialized.

```
WARN -- Concurrent::CachedThreadPool: [DEPRECATED] Method #auto_terminate= has no effect. Set :auto_terminate option when executor is initialized.
```
@joker1007 joker1007 merged commit 9c5f07d into joker1007:master Dec 20, 2023
3 checks passed
@joker1007
Copy link
Owner

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants