Remove duplicate assigned HTTP Status codes #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather have a static list, so our dataset doesn't change across Python versions. |
fcurella
requested changes
Apr 5, 2024
153957
force-pushed
the
http-status-codes
branch
from
1026e86
to
0bdfb22
Compare
153957
force-pushed
the
http-status-codes
branch
from
0bdfb22
to
d3d9b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Remove duplicate entries from
http_assigned_codes.What was wrong
Two values appeared twice in the list skewing the probabilities and making the list harder to maintain.
How this fixes it
Removed duplicate entries.
Remark
Would it be acceptable to replace this hard coded list by values from the
http.HTTPStatusenum included in the Python standard library? (I understand if this repo prefers hard coded lists)Also; that enum has changed in recent Python version, Python 3.9 added 3 additional status codes, including
418 – IM A TEAPOTwhich is not part of the current list because it is considered Unused by the RFC.