"adding height and weight for person provider" #1982
Conversation
| @@ -328,3 +328,31 @@ def suffix_female(self) -> str: | |||
| def language_name(self) -> str: | |||
| """Generate a random i18n language name (e.g. English).""" | |||
| return self.random_element(self.language_names) | |||
|
|
|||
| def height(self, fmt: str = "ft") -> str: | |||
There was a problem hiding this comment.
fmt should probably be of type LiteralString in this case if it only supports a limited set of values. Additionally, I would argue that invalid values should not return imperial units, but just fail. Besides this, I am not sure whether defaulting to ft should really be done or if we have a way to use the current locale for it - speaking of myself, I never actually have to deal with ft.
There was a problem hiding this comment.
the unit should be according to the locale. If a locale only uses one unit (eg: Italy only uses Metric), I wouldn't even have the parameter, and reserve it only for those locales that use both.
There was a problem hiding this comment.
will look into way for using current locale
|
|
||
| """ | ||
| if fmt == "cm": | ||
| return f"{self.random_number(digits=2)} cms" |
There was a problem hiding this comment.
Does the trailing s really make sense here?
There was a problem hiding this comment.
Does the trailing s really make sense here?
No. There is no plural for it...
| else: | ||
| return f"{self.random_number(digits=1)}'{self.random_number(digits=2)}\"" | ||
|
|
||
| def weight(self, fmt: str = "lbs") -> str: |
There was a problem hiding this comment.
I would argue the same as for the height regarding parameter handling here.
|
|
||
| def test_height(self): | ||
| """ | ||
| Test height generation for person |
There was a problem hiding this comment.
| Test height generation for person | |
| Test height generation for person |
|
|
||
| def test_weight(self): | ||
| """ | ||
| Test weight generation for person |
There was a problem hiding this comment.
| Test weight generation for person | |
| Test weight generation for person |
|
I'm not sure if it's appropriate to have this in |
Agreed , we can support the measurements , |
What does this change
Added Height and Weight for the person provider
What was wrong
How this fixes it