Add providers for ms_MY #1976
Add providers for ms_MY #1976
Conversation
Add providers for ms_MY for the address, person, phone_number and ssn. This is porting from the faker php https://github.com/fzaninotto/Faker Signed-off-by: Ng Boon Khai <ngbk1993@yahoo.com>
| "{{firstNameFemaleIndian}} {{lastNameIndian}}", | ||
| ) | ||
|
|
||
| firstNameMaleMalay_tuple = ( |
There was a problem hiding this comment.
Can you add sources for this data?
There was a problem hiding this comment.
Hi @fcurella, they are ported from the php faker https://github.com/fzaninotto/Faker/blob/master/src/Faker/Provider/ms_MY/Person.php
can i just include the github link where it is ported it from?
There was a problem hiding this comment.
You can follow the instructions here
There was a problem hiding this comment.
sure, let me add the faker php link as the source. will update at the next version with the tests file.
I can add some tests to it, but how do i run the test locally? can share the step? |
I had to |
|
In theory it should be easier as documented in the docs at https://github.com/joke2k/faker/blob/master/CONTRIBUTING.rst: Just install |
yes, the pip install step was somehow missing from the CONTRIBUTING.rst, we cant assume that everyone has the tox module installed. Was trying to dry run the tox but somehow i'm getting this output not sure if it is expected PS: The test is running now |
Was following stefan suggestion to try tox, would give this a try if the tox failed |
Yes, this is expected. What tox does here basically is to iterate over the configured Python versions and if it finds the corresponding interpreter, will create an isolated environment, install the required packages there and run the necessary steps like tests there.
Feel free to submit a corresponding PR to improve the docs if you miss something there or something tends to be unclear and could be improved. |
What does this change
Add providers for ms_MY for the address,
person, phone_number and ssn.
This is porting from the faker php
https://github.com/fzaninotto/Faker
Tested with git diff --check and the code is formatted with black --line-length 120
What was wrong
The ms_MY provider is missing.
How this fixes it
Add the ms_MY provider for address, person, phone_number and ssn