Fix determinism in state_abbr()
#1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidCain
force-pushed
the
dcain-fix-state-abbr-determinism
branch
from
a1a77dd
to
7f56120
Compare
Unfortunately, by changing the code to use sets (unordered by definition) from simple tuples, I broke the determinism of `state_abbr()`. Apologies! Changing it back to use a simple ordered collection fixes the problem. (This probably makes sense to ship as 18.3.1, since there's no change in the API)
DavidCain
force-pushed
the
dcain-fix-state-abbr-determinism
branch
from
7f56120
to
9a7a6f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, by changing the code to use sets (unordered by definition) from simple tuples, I broke the determinism of
state_abbr(). Apologies! Changing it back to use a simple ordered collection fixes the problem.(This probably makes sense to ship as 18.3.1, since there's no change in the API)