Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generate pyobject by type #1779 #1822

Merged
merged 3 commits into from Mar 20, 2023
Merged

Implement generate pyobject by type #1779 #1822

merged 3 commits into from Mar 20, 2023

Conversation

dariocurr
Copy link
Contributor

What does this change

It solves issue #1779

Note: I had hard time dealing with mypy and kwargs

faker/providers/python/__init__.py Show resolved Hide resolved
tests/providers/test_python.py Outdated Show resolved Hide resolved
tests/providers/test_python.py Show resolved Hide resolved
@fcurella fcurella self-requested a review March 14, 2023 15:19
Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com>
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dariocurr
Copy link
Contributor Author

Thank your for your useful work

@dariocurr
Copy link
Contributor Author

dariocurr commented Mar 20, 2023

When will it be merged?

@fcurella fcurella merged commit 113d012 into joke2k:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants