Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nl_BE automotive provider #1810

Merged
merged 3 commits into from Mar 20, 2023
Merged

Conversation

takis
Copy link
Contributor

@takis takis commented Feb 28, 2023

No description provided.

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case for the new provider?

@takis
Copy link
Contributor Author

takis commented Mar 13, 2023

Hi Flavio,

Sure! I've added one now.

The black check fails, but the entire file wasn't black-formatted before my patch either. I tried to follow the same
style for the regex, which is what black dislikes.

pattern = foo(
    r"[A-Z]|"
    r"[0-9]"
)

Which black would prefer to see as:

pattern = foo(
    r"[A-Z]|[0-9]"
)

And of course for such a short regex I would agree.

@fcurella
Copy link
Collaborator

@takis We can just accept how black wants it, or we could use # fmt: on/off around that block.

@takis
Copy link
Contributor Author

takis commented Mar 14, 2023

Hi @fcurella

black complaining was caused by the same issue as in the #1820 pull request: I was using the default black configuration for formatting the code omitting the --line-length 120 using in the Makefile.

@takis takis requested a review from fcurella March 17, 2023 07:45
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!

@fcurella fcurella merged commit b019116 into joke2k:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants