Add typing-extensions as dependency and pin mypy version #1557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
The PR adds typing-exntesions as a dependency in
setup.py
and pins the version of mypy to 0.910.What was wrong
@obieler raised the issue that
from typing_extensions import Literal
does not work on python 3.6 and 3.7 without installingtyping-extensions
(#1536).Furthermore the mypy version was not pinned. It is advised to pin the mypy version to avoid that new typing errors appear due to changes in mypy, which would make the CI and errors harder to reproduce (https://sethmlarson.dev/blog/2021-10-18/tests-arent-enough-case-study-after-adding-types-to-urllib3).
How this fixes it
typing-extensions is added as a dependency and solves this issue.