Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pytest to version 6 #1245

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Upgrade pytest to version 6 #1245

merged 1 commit into from
Aug 17, 2020

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented Aug 13, 2020

What does this changes

The unique change affected for 6 version is the mandatory use of keyword arguments in fixtures decorators, proposed in this issue.

What was wrong

Running the test suite with pytest 6 raises next warning error:

Passing arguments to pytest.fixture() as positional arguments is deprecated - pass them as a keyword argument instead

How this fixes it

Use scope='class' in tests/providers/test_barcode.py fixture.

@mondeja mondeja marked this pull request as draft August 13, 2020 16:08
@mondeja mondeja marked this pull request as ready for review August 13, 2020 16:22
@fcurella
Copy link
Collaborator

Thank you!

@fcurella fcurella merged commit a7440ba into joke2k:master Aug 17, 2020
IlfirinPL pushed a commit to IlfirinPL/faker that referenced this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants