Return list instead of tuple in choices_distribution

joke2k · Jul 22, 2021 · cb1bb8e · cb1bb8e
1 parent 52e5018
commit cb1bb8e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/faker/utils/distribution.py b/faker/utils/distribution.py
@@ -61,7 +61,7 @@ def choices_distribution(
 
     if hasattr(random, 'choices'):
         if length == 1 and p is None:
-            return (random.choice(a),)
+            return [random.choice(a)]
         else:
             return random.choices(a, weights=p, k=length)
     else:

diff --git a/tests/providers/__init__.py b/tests/providers/__init__.py
@@ -152,6 +152,11 @@ def test_random_letter(self, faker, num_samples):
             letter = faker.random_letter()
             assert letter.isalpha()
 
+    def test_random_letters(self, faker):
+        assert isinstance(faker.random_letters(length=0), list)
+        assert isinstance(faker.random_letters(length=1), list)
+        assert isinstance(faker.random_letters(length=2), list)
+
     def test_random_lowercase_letter(self, faker, num_samples):
         for _ in range(num_samples):
             letter = faker.random_lowercase_letter()