Upgrade testing suite #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This throws a scary warning while testing, so use the right `$this-expectException...` methods!
This is to match our other tests
This tests internal attribue names using a deprecated method. It's not really testing anything anyway.
These shouldn't be tested anyway.
This helps reduce the amount of indentations
ericpoe
force-pushed
the
upgradeTestingSuite
branch
from
547ff00
to
10c2bf4
Compare
ericpoe
commented
May 3, 2019
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class EventHostsControllerTest extends TestCase | ||
| { | ||
| /** | ||
| * @expectedException \Exception |
There was a problem hiding this comment.
annotation-level exception assertions are deprecated in PHPUnit 8. sebastianbergmann/phpunit#3332
|
@zghosts based on most of our tests, I'd suggest that we use the |
svpernova09
approved these changes
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a few libraries that we use for testing in the CI. This also updates testing documentation since we are not using phing in the VM.
This takes care of #617
I would prefer to fix the style-ci "errors" via php_codesniffer rules in a separate PR since that will involve adding new rules to our
phpcs.xml.distconfig file.